From d151579da59cce019a83d06619566a481c51542a Mon Sep 17 00:00:00 2001
From: Abdenasser <nasser.elidrissi065@gmail.com>
Date: Mon, 4 Nov 2024 22:07:16 +0100
Subject: [PATCH] performance improvement: caching static info

---
 src-tauri/Cargo.lock  | 11 --------
 src-tauri/Cargo.toml  |  1 -
 src-tauri/src/main.rs | 63 ++++++++++++++++++++++++-------------------
 3 files changed, 35 insertions(+), 40 deletions(-)

diff --git a/src-tauri/Cargo.lock b/src-tauri/Cargo.lock
index c43f144..621e67a 100644
--- a/src-tauri/Cargo.lock
+++ b/src-tauri/Cargo.lock
@@ -2016,7 +2016,6 @@ dependencies = [
  "sysinfo",
  "tauri",
  "tauri-build",
- "users",
 ]
 
 [[package]]
@@ -4347,16 +4346,6 @@ dependencies = [
  "serde",
 ]
 
-[[package]]
-name = "users"
-version = "0.11.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "24cc0f6d6f267b73e5a2cadf007ba8f9bc39c6a6f9666f8cf25ea809a153b032"
-dependencies = [
- "libc",
- "log",
-]
-
 [[package]]
 name = "utf-8"
 version = "0.7.6"
diff --git a/src-tauri/Cargo.toml b/src-tauri/Cargo.toml
index 4764451..a7694da 100644
--- a/src-tauri/Cargo.toml
+++ b/src-tauri/Cargo.toml
@@ -13,7 +13,6 @@ serde_json = "1.0"
 serde = { version = "1.0", features = ["derive"] }
 tauri = { version = "1.5", features = ["api-all"] }
 sysinfo = "0.29.0"
-users = "0.11"
 
 [features]
 default = [ "custom-protocol" ]
diff --git a/src-tauri/src/main.rs b/src-tauri/src/main.rs
index 530862f..ae8e302 100644
--- a/src-tauri/src/main.rs
+++ b/src-tauri/src/main.rs
@@ -3,10 +3,21 @@
 use sysinfo::{CpuExt, SystemExt, ProcessExt, System, PidExt, ProcessStatus};
 use tauri::State;
 use std::sync::Mutex;
-use users::{Users, UsersCache};
+use std::time;
+use std::collections::HashMap;
+use std::time::Instant;
 
 struct AppState {
     sys: Mutex<System>,
+    process_cache: Mutex<HashMap<u32, ProcessStaticInfo>>,
+    last_update: Mutex<Instant>,
+}
+
+#[derive(Clone)]
+struct ProcessStaticInfo {
+    name: String,
+    command: String,
+    user: String,
 }
 
 #[derive(serde::Serialize)]
@@ -34,48 +45,42 @@ struct SystemStats {
 #[tauri::command]
 async fn get_processes(state: State<'_, AppState>) -> Result<(Vec<ProcessInfo>, SystemStats), String> {
     let mut sys = state.sys.lock().map_err(|_| "Failed to lock system state")?;
-    sys.refresh_processes();
-    sys.refresh_memory();
-    sys.refresh_cpu();
-
-    let users_cache = UsersCache::new();
+    let mut process_cache = state.process_cache.lock().map_err(|_| "Failed to lock process cache")?;
+    
+    // Batch refresh system information
+    sys.refresh_all();
 
     let processes = sys.processes()
         .iter()
         .map(|(pid, process)| {
+            let pid_u32 = pid.as_u32();
+            
+            // Get or update cache for static process info
+            let static_info = process_cache.entry(pid_u32).or_insert_with(|| {
+                ProcessStaticInfo {
+                    name: process.name().to_string(),
+                    command: process.cmd().join(" "),
+                    user: process.user_id()
+                        .map_or_else(|| "-".to_string(), |uid| uid.to_string()),
+                }
+            });
+
             let status = match process.status() {
                 ProcessStatus::Run => "Running",
                 ProcessStatus::Sleep => "Sleeping",
                 ProcessStatus::Idle => "Idle",
-                ProcessStatus::Stop => "Stopped",
-                ProcessStatus::Zombie => "Zombie",
-                ProcessStatus::Tracing => "Tracing",
-                ProcessStatus::Dead => "Dead",
-                ProcessStatus::Wakekill => "Wake Kill",
-                ProcessStatus::Waking => "Waking",
-                ProcessStatus::Parked => "Parked",
-                ProcessStatus::LockBlocked => "Lock Blocked",
-                ProcessStatus::UninterruptibleDiskSleep => "Disk Sleep",
-                ProcessStatus::Unknown(_) => "Unknown"
+                _ => "Unknown"
             };
 
-            let user = process.user_id()
-                .and_then(|uid| {
-                    let uid_num = uid.to_string().parse::<u32>().unwrap_or(0);
-                    users_cache.get_user_by_uid(uid_num)
-                        .map(|user| format!("{} ({})", user.name().to_string_lossy(), uid_num))
-                })
-                .unwrap_or_else(|| "-".to_string());
-
             ProcessInfo {
-                pid: pid.as_u32(),
+                pid: pid_u32,
                 ppid: process.parent().unwrap_or(sysinfo::Pid::from(0)).as_u32(),
-                name: process.name().to_string(),
+                name: static_info.name.clone(),
                 cpu_usage: process.cpu_usage(),
                 memory_usage: process.memory(),
                 status: status.to_string(),
-                user,
-                command: process.cmd().join(" "),
+                user: static_info.user.clone(),
+                command: static_info.command.clone(),
                 threads: None,
             }
         })
@@ -107,6 +112,8 @@ fn main() {
     tauri::Builder::default()
         .manage(AppState {
             sys: Mutex::new(System::new_all()),
+            process_cache: Mutex::new(HashMap::new()),
+            last_update: Mutex::new(Instant::now()),
         })
         .invoke_handler(tauri::generate_handler![
             get_processes,