From a075ccfcec9070b51955e4aeb4d39fd9ffb78962 Mon Sep 17 00:00:00 2001 From: Huakun Shen Date: Sun, 16 Feb 2025 02:50:16 -0500 Subject: [PATCH] log(desktop): add log messages for shell permission check Show more information in log if shell permission denied --- packages/api/src/api/server/shell.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/api/src/api/server/shell.ts b/packages/api/src/api/server/shell.ts index d994f2d..f6cf461 100644 --- a/packages/api/src/api/server/shell.ts +++ b/packages/api/src/api/server/shell.ts @@ -47,7 +47,10 @@ async function verifyShellCmdPermission( if (requiredPermissions.includes(permission.permission)) { for (const deny of permission.deny || []) { if (deny.cmd && deny.cmd.program === program && matchRegexArgs(args, deny.cmd.args || [])) { - return Promise.reject("Shell Command Permission Denied by deny rule") + console.warn("deny matched", deny) + return Promise.reject( + `Shell Command Permission Denied by deny rule: ${JSON.stringify(deny)}` + ) } } for (const allow of permission.allow || []) { @@ -61,7 +64,11 @@ async function verifyShellCmdPermission( } } } - return Promise.reject("Shell Command Permission Denied, no allow rule found") + console.warn("program", program) + console.warn("args", args) + console.warn("requiredPermissions", requiredPermissions) + console.warn("userPermissionScopes", userPermissionScopes) + return Promise.reject(`Shell Command Permission Denied, no allow rule found.`) } /**