From 7c68a8d70fa26c80ae33a72c7493c7a6e93013f9 Mon Sep 17 00:00:00 2001 From: Huakun Shen Date: Tue, 7 Jan 2025 16:12:28 -0500 Subject: [PATCH] feat: disable folder name check in cli package In the new extension loading design, we don't require the folder name to match extension identifier --- apps/cli/CHANGELOG.md | 6 ++++++ apps/cli/package.json | 5 +++-- apps/cli/src/commands/verify.ts | 10 ++-------- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/apps/cli/CHANGELOG.md b/apps/cli/CHANGELOG.md index 188544b..68709f0 100644 --- a/apps/cli/CHANGELOG.md +++ b/apps/cli/CHANGELOG.md @@ -1,5 +1,11 @@ # kksh +## 0.0.29 + +### Patch Changes + +- Disable check for folder name. identifier and folder name no longer need to be the same. + ## 0.0.28 ### Patch Changes diff --git a/apps/cli/package.json b/apps/cli/package.json index 30bc3b7..b6b84c3 100644 --- a/apps/cli/package.json +++ b/apps/cli/package.json @@ -1,7 +1,7 @@ { "name": "kksh", "module": "dist/cli.js", - "version": "0.0.28", + "version": "0.0.29", "type": "module", "bin": { "kksh": "./dist/cli.js", @@ -10,7 +10,8 @@ "author": "Huakun", "scripts": { "build": "bun build.ts", - "test": "cross-env NODE_ENV=test bun test --coverage" + "test": "cross-env NODE_ENV=test bun test --coverage", + "check-types": "tsc --noEmit" }, "devDependencies": { "@types/bun": "latest", diff --git a/apps/cli/src/commands/verify.ts b/apps/cli/src/commands/verify.ts index d6d1f6b..9853018 100644 --- a/apps/cli/src/commands/verify.ts +++ b/apps/cli/src/commands/verify.ts @@ -66,18 +66,12 @@ export function verifySingleProject(projectPath: string): boolean { pkg.kunkun.identifier = folderName // } } - if (pkg.kunkun.identifier !== folderName) { - logger.error( - `Extension package name at [pkg.kunkun.identifier](${pkg.kunkun.identifier}) is not the same as the folder name [${folderName}], please fix it` - ) - return false - } - for (const cmd of pkg.kunkun.customUiCmds) { + for (const cmd of pkg.kunkun.customUiCmds ?? []) { if (!verifyCustomUiCommand(projectPath, cmd)) { return false } } - for (const cmd of pkg.kunkun.templateUiCmds) { + for (const cmd of pkg.kunkun.templateUiCmds ?? []) { if (!verifyTemplateUiCommand(projectPath, cmd)) { return false }