From 0af6ef2d0a5d65aec8413e5c9d3e7a6b57e4ae55 Mon Sep 17 00:00:00 2001
From: Huakun Shen <huakun.shen@huakunshen.com>
Date: Sat, 11 Jan 2025 21:58:27 -0500
Subject: [PATCH] refactor: enhance extension installation process with
 overwrite confirmation

if store extension exists in DB but not disk, also ask if need to overwrite it.
---
 .../extension/store/[identifier]/+page.svelte |  2 --
 packages/extension/src/install.ts             | 19 +++++++++++++++++++
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/apps/desktop/src/routes/app/extension/store/[identifier]/+page.svelte b/apps/desktop/src/routes/app/extension/store/[identifier]/+page.svelte
index 488a59a..c42737f 100644
--- a/apps/desktop/src/routes/app/extension/store/[identifier]/+page.svelte
+++ b/apps/desktop/src/routes/app/extension/store/[identifier]/+page.svelte
@@ -81,7 +81,6 @@
 			.installFromTarballUrl(tarballUrl, installDir, installExtras)
 			.then(() => toast.success(`Plugin ${ext.name} Installed`))
 			.then((loadedExt) => {
-				console.log("loadedExt", loadedExt);
 				supabaseAPI.incrementDownloads({
 					identifier: ext.identifier,
 					version: ext.version
@@ -151,7 +150,6 @@
 </script>
 
 <svelte:window on:keydown={handleKeydown} />
-<Button onclick={() => toast.success("Hello")}>Toast</Button>
 <Button
 	variant="outline"
 	size="icon"
diff --git a/packages/extension/src/install.ts b/packages/extension/src/install.ts
index 3ee32c9..62eedfe 100644
--- a/packages/extension/src/install.ts
+++ b/packages/extension/src/install.ts
@@ -55,6 +55,25 @@ export async function installTarball(
 				}
 				await fs.remove(extInstallPath, { recursive: true })
 			}
+
+			// find extension in db, if exists, ask user if they want to overwrite it
+			const exts = await db.getAllExtensionsByIdentifier(manifest.kunkun.identifier)
+			if (exts.length > 0) {
+				const overwrite = await dialog.ask(
+					`Extension ${manifest.kunkun.identifier} already exists in database (but not on disk), do you want to overwrite it?`
+				)
+				if (!overwrite) {
+					return Promise.reject("Extension Already Exists")
+				}
+				if (exts[0].path) {
+					console.log(
+						"delete extension in db (overwrite in order to install a new version)",
+						exts[0].path
+					)
+					await db.deleteExtensionByPath(exts[0].path)
+				}
+			}
+
 			await fs.rename(decompressDest, extInstallPath)
 			await db.createExtension({
 				identifier: manifest.kunkun.identifier,